chore(term): add descriptive error on Windows for lack of VT #32
Conversation
|
After further investigation, it looks like the error in #29 is unrelated to Visual Studio 2019. All windows SDKs that are available to install with the Visual Studio 2019 installer have this defined. The main way of running into this issue seems to be when using an old mingw build, in particular, a build with a mingw runtime older than v7. |
|
@tobil4sk so the check is still relevant, but the message must be changed: #error 2019 and older toolchains are not supported. Update the toolchain or revert to Luasystem < 0.4should become #error Virtual terminal macros are undefined (eg. ENABLE_VIRTUAL_TERMINAL_INPUT). Update the toolchain or revert to Luasystem < 0.4correct? |
Yes, that works. I think the most likely way to run into this is by using an old version of mingw (people might install it because the latest build that shows up on sourceforge is very old), but a generic message like this works too. |
Tieske
force-pushed
the
vtperror
branch
2 times, most recently
from
6c3ac22
to
da7c280
Compare
|
@o-lim I think this is good to go now. Please have a look. |
src/term.c
Outdated
| @@ -107,6 +107,11 @@ typedef struct ls_RegConst { | |||
| // This is needed because some flags are not defined on all platforms. So we | |||
| // still export the constants, but they will be all 0, and hence not do anything. | |||
| #ifdef _WIN32 | |||
| // check compatibility: Windows virtual terminal processing was added in 2019, | |||
There was a problem hiding this comment.
This was added before 2019, so maybe it's best to change this comment too.
There was a problem hiding this comment.
you are correct, thx. New Windows Terminal app was added in 2019, but virtual processing was added in 2015. I'll update accordingly.
There was a problem hiding this comment.
@tobil4sk please check the updated comment
if no virtual terminal processing is available, raise a descriptive error instead of a failure on some missing defines.
if no virtual terminal processing is available, raise a descriptive error instead of a failure on some missing defines.
closes #29